Closed
Conversation
This was referenced Aug 29, 2025
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-ready to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 29, 2025
Closed
GraDKh
force-pushed
the
dgordon/add_prover_binary
branch
from
9362d63 to
75a71f2
Compare
GraDKh
force-pushed
the
gordon/dd_save_command
branch
2 times, most recently
from
0c61270 to
5f45183
Compare
GraDKh
force-pushed
the
dgordon/add_prover_binary
branch
from
75a71f2 to
d329051
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
GraDKh
force-pushed
the
dgordon/add_prover_binary
branch
from
d329051 to
f5e580a
Compare
GraDKh
force-pushed
the
gordon/dd_save_command
branch
from
5f45183 to
06a3624
Compare
jadnohra
reviewed
Sep 1, 2025
jadnohra
reviewed
Sep 1, 2025
GraDKh
force-pushed
the
dgordon/add_prover_binary
branch
from
f5e580a to
a5c74d3
Compare
GraDKh
force-pushed
the
gordon/dd_save_command
branch
from
06a3624 to
d112b72
Compare
Contributor
Author
|
Addressed both |
GraDKh
force-pushed
the
dgordon/add_prover_binary
branch
from
a5c74d3 to
3eeb7cf
Compare
Comment on lines
+88
to
+93
| if let Some(parent) = args.proof_path.parent() | ||
| && !parent.as_os_str().is_empty() | ||
| { | ||
| fs::create_dir_all(parent) | ||
| .with_context(|| format!("Failed to create parent directory {}", parent.display()))?; | ||
| } |
There was a problem hiding this comment.
The parent.as_os_str().is_empty() check is unnecessary here. When Path::parent() returns Some(parent), the parent path is never empty - it would return None for a path with no parent component. The condition can be simplified to:
if let Some(parent) = args.proof_path.parent() {
fs::create_dir_all(parent)
.with_context(|| format!("Failed to create parent directory {}", parent.display()))?;
}This maintains the same behavior while removing the redundant check.
Suggested change
| if let Some(parent) = args.proof_path.parent() | |
| && !parent.as_os_str().is_empty() | |
| { | |
| fs::create_dir_all(parent) | |
| .with_context(|| format!("Failed to create parent directory {}", parent.display()))?; | |
| } | |
| if let Some(parent) = args.proof_path.parent() | |
| { | |
| fs::create_dir_all(parent) | |
| .with_context(|| format!("Failed to create parent directory {}", parent.display()))?; | |
| } |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
jadnohra
force-pushed
the
dgordon/add_prover_binary
branch
from
3eeb7cf to
dfbed87
Compare
jadnohra
force-pushed
the
gordon/dd_save_command
branch
from
d112b72 to
5886785
Compare
This was referenced Sep 1, 2025
Closed
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Sep 2, 2025
### TL;DR
Added a standalone prover binary example that can generate proofs from serialized constraint systems and witnesses.
### What changed?
- Added a new `prover` example binary that reads a constraint system and witness data from disk and produces a serialized proof
- Implemented a `From<ValuesData<'a>>` trait for `Vec<Word>` to simplify conversion of witness data
- Updated the examples README with documentation for the new prover binary, including usage instructions
- Added the binary to the examples crate manifest
### How to test?
1. Generate artifacts from an example circuit:
```
cargo run --release --example sha256 -- save \
--cs-path out/sha256/cs.bin \
--pub-witness-path out/sha256/public.bin \
--non-pub-data-path out/sha256/non_public.bin
```
1. Produce a proof using the new prover binary:
```
cargo run --release --example prover -- \
--cs-path out/sha256/cs.bin \
--pub-witness-path out/sha256/public.bin \
--non-pub-data-path out/sha256/non_public.bin \
--proof-path out/sha256/proof.bin \
--log-inv-rate 1
```
### Why make this change?
This change enables cross-host proof generation pipelines by providing a standalone binary that can generate proofs from serialized inputs. This is useful for scenarios where the constraint system is generated on one machine but the proof needs to be generated on another, potentially more powerful machine optimized for proving.
lockedloop
pushed a commit
that referenced
this pull request
Sep 8, 2025
### TL;DR
Added a standalone prover binary example that can generate proofs from serialized constraint systems and witnesses.
### What changed?
- Added a new `prover` example binary that reads a constraint system and witness data from disk and produces a serialized proof
- Implemented a `From<ValuesData<'a>>` trait for `Vec<Word>` to simplify conversion of witness data
- Updated the examples README with documentation for the new prover binary, including usage instructions
- Added the binary to the examples crate manifest
### How to test?
1. Generate artifacts from an example circuit:
```
cargo run --release --example sha256 -- save \
--cs-path out/sha256/cs.bin \
--pub-witness-path out/sha256/public.bin \
--non-pub-data-path out/sha256/non_public.bin
```
1. Produce a proof using the new prover binary:
```
cargo run --release --example prover -- \
--cs-path out/sha256/cs.bin \
--pub-witness-path out/sha256/public.bin \
--non-pub-data-path out/sha256/non_public.bin \
--proof-path out/sha256/proof.bin \
--log-inv-rate 1
```
### Why make this change?
This change enables cross-host proof generation pipelines by providing a standalone binary that can generate proofs from serialized inputs. This is useful for scenarios where the constraint system is generated on one machine but the proof needs to be generated on another, potentially more powerful machine optimized for proving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Added a standalone prover binary example that can generate proofs from serialized constraint systems and witnesses.
What changed?
proverexample binary that reads a constraint system and witness data from disk and produces a serialized proofFrom<ValuesData<'a>>trait forVec<Word>to simplify conversion of witness dataHow to test?
Why make this change?
This change enables cross-host proof generation pipelines by providing a standalone binary that can generate proofs from serialized inputs. This is useful for scenarios where the constraint system is generated on one machine but the proof needs to be generated on another, potentially more powerful machine optimized for proving.